Skip to content

feat: Support configuring ListenerClass preset (with sensible defaults) #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 28, 2025
Merged

feat: Support configuring ListenerClass preset (with sensible defaults) #414

merged 14 commits into from
Oct 28, 2025
+159 −7

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 23, 2025 •
edited by NickLarsenNZ
Loading

Description

Part of stackabletech/issues#770

With recent changes from stackabletech/issues#770, stackablectl demo install on kind broke, as kind by default does not have a LoadBalancer installed.

We could try to document/automate/whatnot this, but I expect significant user problems with this. So instead we can make stackablectl a little bit more clever and detect kind and k3s and don't use LoadBalancers in that case.

stackablectl now tries the following order and simple passes the result to the listener-operator helm-chart:

  1. Use --listener-class-preset flag
  2. If not set determine Kubernetes environment (kind, k3, IONOS) by looking at nodes and use according defaults
  3. If any error occurs, default to ephemeral-nodes

PS: Yes I know the OnceCell is not ideal, but I hope this is a temporary feature until #406 is implemented properly.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer mentioned this pull request Oct 23, 2025
Closed
15 tasks
@sbernauer sbernauer marked this pull request as ready for review October 23, 2025 11:21
@sbernauer sbernauer self-assigned this Oct 23, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Oct 23, 2025
@sbernauer sbernauer changed the title feat: Support configuring listner-operator preset (with sensible defaults) feat: Support configuring listener-operator preset (with sensible defaults) Oct 23, 2025
NickLarsenNZ
NickLarsenNZ reviewed Oct 24, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ requested changes Oct 24, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some recommended changes.

I will update the PR description.

I also think "preset" should be plural: "presets", but that's outside of the scope of this and would need to change in the chart.

@NickLarsenNZ NickLarsenNZ changed the title feat: Support configuring listener-operator preset (with sensible defaults) feat: Support configuring ListenerClass preset (with sensible defaults) Oct 24, 2025
@sbernauer
Copy link
Member Author

sbernauer commented Oct 24, 2025 •
edited by NickLarsenNZ
Loading

I also think "preset" should be plural: "presets", but that's outside of the scope of this and would need to change in the chart.

Hmm, I think preset is technically more correct, as it's e.g. "stable-nodes".
Yes, that produces 1..n ListenerClasses, but it's still a single preset, isn't it?

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 24, 2025
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Oct 28, 2025 •
edited
Loading

I also think "preset" should be plural: "presets", but that's outside of the scope of this and would need to change in the chart.

Hmm, I think preset is technically more correct, as it's e.g. "stable-nodes". Yes, that produces 1..n ListenerClasses, but it's still a single preset, isn't it?

yeah I guess it can be interpreted both ways. I tend to think what it results in... It results in a number of preset ListenerClasses (which are the presets).

Anyway, keep as is because it is valid too.

That said, the docs say "presets": https://docs.stackable.tech/home/nightly/listener-operator/listenerclass/#presets

NickLarsenNZ
NickLarsenNZ reviewed Oct 28, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ reviewed Oct 28, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Oct 28, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 28, 2025
Merged via the queue into main with commit e58f921 Oct 28, 2025
21 of 22 checks passed
@sbernauer sbernauer deleted the feat/listener-op-preset branch October 28, 2025 13:27
@sbernauer sbernauer mentioned this pull request Oct 29, 2025
Merged
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @NickLarsenNZ